Updated the logic

samsmithnz · Aug 9, 2023 · b5de1c1 · b5de1c1
1 parent 77fa436
commit b5de1c1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/RepoGovernance.Core/Models/AzureAppRegistration.cs b/src/RepoGovernance.Core/Models/AzureAppRegistration.cs
@@ -14,9 +14,8 @@ public string ExpirationDateString
                 }
                 else
                 {
-                    return "No Expiration Date Found";
+                    return "No expiration date found";
                 }
-
             }
         }
         public DateTimeOffset? ExpirationDate
@@ -26,7 +25,7 @@ public string ExpirationDateString
                 DateTimeOffset? minDate = null;
                 foreach (DateTimeOffset? item in ExpirationDates)
                 {
-                    if (item != null && item < minDate)
+                    if (item != null && (minDate == null || item < minDate))
                     {
                         minDate = item;
                     }

diff --git a/src/RepoGovernance.Tests/AzureApiTests.cs b/src/RepoGovernance.Tests/AzureApiTests.cs
@@ -61,6 +61,7 @@ public async Task GetApplicationsItemTest()
             Assert.IsNotNull(result);
             Assert.AreEqual(2, result.AppRegistrations.Count);
             Assert.AreEqual(1, result.AppRegistrations[0].ExpirationDates.Count);
+            Assert.IsNotNull(result.AppRegistrations[0].ExpirationDate);
             Assert.AreEqual(1, result.AppRegistrations[1].ExpirationDates.Count);
         }