Allow defining a job priority [implements #56] #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realised the description is a little vague here. What's the preferred place for me to put any tests related to this new new field? How many tests are sufficient? Is setting a default value okay in this case? |
KushalP
force-pushed
the
add-job-priority
branch
3 times, most recently
from
4a99217
to
7a7d902
Compare
Defining a default priority --------------------------- It makes sense to provide a default priority where possible. This way the implementation is backwards compatible for any users who are implementing their own jobs with `Rihanna.Job`. The lowest priority is the default, allowing developers to increase the priority of their jobs as/when they need to. The default priority value -------------------------- A default of 19 has been chosen to conform with the Unix process priority scale[1] [1] https://en.wikipedia.org/wiki/Nice_(Unix)
KushalP
force-pushed
the
add-job-priority
branch
6 times, most recently
from
3119635
to
7d695c3
Compare
This allows developers to define their own priorities for jobs.
KushalP
force-pushed
the
add-job-priority
branch
from
7d695c3
to
6fc7f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress PR.
Tasks
prioritycolumnrihanna_jobs_enqueued_at_idindex to useprioritycolumnprioritymethod onRihanna.JobTesting
What's the preferred way to test this behaviour? I'm a little confused with the style taken. If you could provide a single sample test case, that's probably sufficient here.