Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Feature/datetime #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/datetime #10

wants to merge 2 commits into from

Conversation

antoyo
Copy link
Contributor

@antoyo antoyo commented Sep 7, 2018

No description provided.

@antoyo antoyo added the wip label Sep 7, 2018
@antoyo antoyo force-pushed the feature/datetime branch 2 times, most recently from 2720a3e to d22c4e7 Compare September 10, 2018 20:58
Copy link

@psyomn psyomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough. It's nice to have basic time formatting out of the box, so this will definitely be useful.

@antoyo
Copy link
Contributor Author

antoyo commented Sep 11, 2018

@psyomn: I was also wondering if I should implement the stuff marked with unimplemented!() and the locale-dependent stuff.
What do you think, @eloraiby?

@psyomn
Copy link

psyomn commented Sep 11, 2018

IMHO, it looks like basic functionality is there, and I don't think I've regularly used any of the unimplemented ones. We can implement them later.

One addition I can think of is perhaps rfcs for datetime formatting, kind of like how go does it, but I think that would add unnecessary clutter.

@antoyo antoyo mentioned this pull request Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants