Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GVRAccelerateDecelerateInterpolator::mapRatio(float) - Negative infinity #21

Closed
nathanalmeida opened this issue Apr 17, 2015 · 1 comment
Closed

GVRAccelerateDecelerateInterpolator::mapRatio(float) - Negative infinity #21

nathanalmeida opened this issue Apr 17, 2015 · 1 comment

Comments

@nathanalmeida
Copy link
Contributor

A map ratio for positive infinity value returns NAN instead of NEGATIVE_INFINITY

public void testMapRatioNegativeInfinity() {
        GVRAccelerateDecelerateInterpolator interpolator = GVRAccelerateDecelerateInterpolator.getInstance();
        assertEquals(interpolator.mapRatio(Float.NEGATIVE_INFINITY), Float.NEGATIVE_INFINITY);
}
@JonShemitz
Copy link
Contributor

I'm not sure there's any point to testing this parameter: This is not user-facing code; it is only called by the animation engine, and the inputs are always in the range [0, 1].

danke-sra pushed a commit to danke-sra/GearVRf that referenced this issue Oct 30, 2015
@sukhwanyoon
Merge pull request Samsung#21 from sukhwanyoon/cleancode
76f447d 
[GVRF] cleaned unnecessary commented lines
@dnvasilev dnvasilev mentioned this issue Sep 5, 2017
Closed
xcaostagit added a commit to xcaostagit/GearVRf that referenced this issue Nov 28, 2017
@xcaostagit
JSR-223 support binary update.
7a4af54 
The existing version will cause SIGABRT when executing the following
script (from inside panel.x3d in the project gvr-x3d-360video -
        function isOver(val)
        {
            if (val == true)
            {
                diffuseColor_changed = new SFColor(.8, .8, .8);
            }
            else
            {
                diffuseColor_changed = new SFColor(.7, .7, .7);
            }
        }

Below is the crash log -

11-06 16:37:31.341 10781 10781 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
11-06 16:37:31.341 10781 10781 F DEBUG   : Build fingerprint: 'samsung/dreamqltesq/dreamqltesq:7.0/NRD90M/G950USQU1AQFJ:eng/test-keys'
11-06 16:37:31.341 10781 10781 F DEBUG   : Revision: '12'
11-06 16:37:31.342 10781 10781 F DEBUG   : ABI: 'arm'
11-06 16:37:31.342 10781 10781 F DEBUG   : pid: 10664, tid: 10682, name: GLThread 526  >>> com.samsung.smcl.vr.gvrf_launcher <<<
11-06 16:37:31.342 10781 10781 F DEBUG   : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
11-06 16:37:31.350 10781 10781 F DEBUG   : Abort message: 'art/runtime/java_vm_ext.cc:470] JNI DETECTED ERROR IN APPLICATION: JNI GetMethodID called with pending exception java.lang.IllegalArgumentException: method org.gearvrf.x3d.data_types.SFColor.<init> argument 1 has type float, got java.lang.Double'
11-06 16:37:31.350 10781 10781 F DEBUG   :     r0 00000000  r1 000029ba  r2 00000006  r3 00000008
11-06 16:37:31.350 10781 10781 F DEBUG   :     r4 cfc75978  r5 00000006  r6 cfc75920  r7 0000010c
11-06 16:37:31.350 10781 10781 F DEBUG   :     r8 00000000  r9 ed39c7ac  sl 00001886  fp ed361f6f
11-06 16:37:31.350 10781 10781 F DEBUG   :     ip 0000000b  sp cfc72d10  lr eff22ba7  pc eff254a0  cpsr 200f0010
11-06 16:37:31.369 10781 10781 F DEBUG   :
11-06 16:37:31.369 10781 10781 F DEBUG   : backtrace:
11-06 16:37:31.370 10781 10781 F DEBUG   :     #00 pc 0004b4a0  /system/lib/libc.so (tgkill+12)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#1 pc 00048ba3  /system/lib/libc.so (pthread_kill+34)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#2 pc 0001e1b9  /system/lib/libc.so (raise+10)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#3 pc 000197a5  /system/lib/libc.so (__libc_android_abort+34)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#4 pc 00017540  /system/lib/libc.so (abort+4)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#5 pc 00342ccd  /system/lib/libart.so (_ZN3art7Runtime5AbortEv+252)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#6 pc 000b6b57  /system/lib/libart.so (_ZN3art10LogMessageD2Ev+870)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#7 pc 00252adb  /system/lib/libart.so (_ZN3art9JavaVMExt8JniAbortEPKcS2_+1226)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#8 pc 00252b85  /system/lib/libart.so (_ZN3art9JavaVMExt9JniAbortVEPKcS2_St9__va_list+64)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#9 pc 000cd0cb  /system/lib/libart.so (_ZN3art11ScopedCheck6AbortFEPKcz+46)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#10 pc 000cccbb  /system/lib/libart.so (_ZN3art11ScopedCheck11CheckThreadEP7_JNIEnv+362)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#11 pc 000cbcdf  /system/lib/libart.so (_ZN3art11ScopedCheck22CheckPossibleHeapValueERNS_18ScopedObjectAccessEcNS_12JniValueTypeE+26)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#12 pc 000cb07f  /system/lib/libart.so (_ZN3art11ScopedCheck5CheckERNS_18ScopedObjectAccessEbPKcPNS_12JniValueTypeE+810)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#13 pc 000ce1d9  /system/lib/libart.so (_ZN3art8CheckJNI19GetMethodIDInternalEPKcP7_JNIEnvP7_jclassS2_S2_b+460)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#14 pc 000c402d  /system/lib/libart.so (_ZN3art8CheckJNI11GetMethodIDEP7_JNIEnvP7_jclassPKcS6_+24)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#15 pc 0031d1f9  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN3Env12getClassNameEP7_jclass+304)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#16 pc 0030ebcd  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN12CJavaContext11ConstructorERKN2v820FunctionCallbackInfoINS0_5ValueEEE+320)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#17 pc 007d470c  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN2v88internal25FunctionCallbackArguments4CallEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEE+188)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#18 pc 00810c5c  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#19 pc 008113f8  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#20 pc 008117fc  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN2v88internal21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE+72)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#21 pc 00000098  <anonymous:cbc06000>
@xcaostagit xcaostagit mentioned this issue Nov 28, 2017
Closed
liaxim added a commit to liaxim/GearVRf that referenced this issue Nov 13, 2018
@liaxim
Abstract body tracking API (Samsung#21)
4485a26 
Add GVRBodyTracker to provide an abstract body tracking component which captures camera images.
NolaDonato added a commit to NolaDonato/GearVRf that referenced this issue Dec 4, 2018
@NolaDonato
Abstract body tracking API
34fcc56 
Same as PR Samsung#21 from sxrsdk
@NolaDonato NolaDonato mentioned this issue Dec 4, 2018
Merged
liaxim pushed a commit that referenced this issue Dec 4, 2018
@NolaDonato @liaxim
Abstract body tracking API
01956ba 
Same as PR #21 from sxrsdk
liaxim pushed a commit that referenced this issue Dec 10, 2018
@NolaDonato @liaxim
Update MixedReality to be compatible with SXR (#2023)
234aff9 
* Abstract body tracking API 

Same as PR #21 from sxrsdk

* Update MixedReality to be compatible with SXR

These changes didn't manage to make it into GearVRf before SDC

* fixed hit testing in box collider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nathanalmeida @JonShemitz