Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove two warnings. #4

Closed
wants to merge 0 commits into from
Closed

Remove two warnings. #4

wants to merge 0 commits into from

Conversation

JonShemitz
Copy link
Contributor

Source code is warning-free, again.

Change-Id: I53613c481dff66d7012188857f1560206a593ff3

GearVRf-DCO-1.0-Signed-off-by: Jon Shemitz
j.shemitz@samsung.com

@chenchao1407
Copy link
Contributor

Hi Jon.

In my case I still can see one more Warning in org.gearvrf.debug.GVRConsole

There is one unused import "import org.gearvrf.debug.GVRConsole.EyeMode;"

Can you help check this?

Thanks in advance.

@JonShemitz
Copy link
Contributor Author

This is why I wanted to amend the checkin ...

@chenchao1407
Copy link
Contributor

Hi Jon.

I think you can amend the check-in(or do a rebase and then modify the check-in) and push to your repo and then the pull request will be automatically updated.

Thanks

@JonShemitz JonShemitz closed this Apr 8, 2015
@JonShemitz
Copy link
Contributor Author

I do not know what I did that closed this, but I suspect it was forcing my master into sync with the public repository.

@chenchao1407 chenchao1407 mentioned this pull request May 1, 2015
Merged
@ethernyEonian ethernyEonian mentioned this pull request Oct 10, 2015
Closed
danke-sra referenced this pull request in danke-sra/GearVRf Oct 30, 2015
Merge pull request #4 from danke-sra/master
a05c7ca 
GVRF: Fix compilation issue with new Android NDK (r10e)
@parthmehta209 parthmehta209 mentioned this pull request Aug 11, 2016
Closed
@thomasflynn thomasflynn mentioned this pull request Aug 22, 2016
Merged
@NolaDonato NolaDonato mentioned this pull request Aug 31, 2016
Merged
@NolaDonato NolaDonato mentioned this pull request Oct 5, 2016
Closed
@dnvasilev dnvasilev mentioned this pull request Sep 5, 2017
Closed
xcaostagit added a commit to xcaostagit/GearVRf that referenced this pull request Nov 28, 2017
@xcaostagit
JSR-223 support binary update.
7a4af54 
The existing version will cause SIGABRT when executing the following
script (from inside panel.x3d in the project gvr-x3d-360video -
        function isOver(val)
        {
            if (val == true)
            {
                diffuseColor_changed = new SFColor(.8, .8, .8);
            }
            else
            {
                diffuseColor_changed = new SFColor(.7, .7, .7);
            }
        }

Below is the crash log -

11-06 16:37:31.341 10781 10781 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
11-06 16:37:31.341 10781 10781 F DEBUG   : Build fingerprint: 'samsung/dreamqltesq/dreamqltesq:7.0/NRD90M/G950USQU1AQFJ:eng/test-keys'
11-06 16:37:31.341 10781 10781 F DEBUG   : Revision: '12'
11-06 16:37:31.342 10781 10781 F DEBUG   : ABI: 'arm'
11-06 16:37:31.342 10781 10781 F DEBUG   : pid: 10664, tid: 10682, name: GLThread 526  >>> com.samsung.smcl.vr.gvrf_launcher <<<
11-06 16:37:31.342 10781 10781 F DEBUG   : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
11-06 16:37:31.350 10781 10781 F DEBUG   : Abort message: 'art/runtime/java_vm_ext.cc:470] JNI DETECTED ERROR IN APPLICATION: JNI GetMethodID called with pending exception java.lang.IllegalArgumentException: method org.gearvrf.x3d.data_types.SFColor.<init> argument 1 has type float, got java.lang.Double'
11-06 16:37:31.350 10781 10781 F DEBUG   :     r0 00000000  r1 000029ba  r2 00000006  r3 00000008
11-06 16:37:31.350 10781 10781 F DEBUG   :     r4 cfc75978  r5 00000006  r6 cfc75920  r7 0000010c
11-06 16:37:31.350 10781 10781 F DEBUG   :     r8 00000000  r9 ed39c7ac  sl 00001886  fp ed361f6f
11-06 16:37:31.350 10781 10781 F DEBUG   :     ip 0000000b  sp cfc72d10  lr eff22ba7  pc eff254a0  cpsr 200f0010
11-06 16:37:31.369 10781 10781 F DEBUG   :
11-06 16:37:31.369 10781 10781 F DEBUG   : backtrace:
11-06 16:37:31.370 10781 10781 F DEBUG   :     #00 pc 0004b4a0  /system/lib/libc.so (tgkill+12)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#1 pc 00048ba3  /system/lib/libc.so (pthread_kill+34)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#2 pc 0001e1b9  /system/lib/libc.so (raise+10)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#3 pc 000197a5  /system/lib/libc.so (__libc_android_abort+34)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#4 pc 00017540  /system/lib/libc.so (abort+4)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#5 pc 00342ccd  /system/lib/libart.so (_ZN3art7Runtime5AbortEv+252)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#6 pc 000b6b57  /system/lib/libart.so (_ZN3art10LogMessageD2Ev+870)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#7 pc 00252adb  /system/lib/libart.so (_ZN3art9JavaVMExt8JniAbortEPKcS2_+1226)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#8 pc 00252b85  /system/lib/libart.so (_ZN3art9JavaVMExt9JniAbortVEPKcS2_St9__va_list+64)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#9 pc 000cd0cb  /system/lib/libart.so (_ZN3art11ScopedCheck6AbortFEPKcz+46)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#10 pc 000cccbb  /system/lib/libart.so (_ZN3art11ScopedCheck11CheckThreadEP7_JNIEnv+362)
11-06 16:37:31.370 10781 10781 F DEBUG   :     Samsung#11 pc 000cbcdf  /system/lib/libart.so (_ZN3art11ScopedCheck22CheckPossibleHeapValueERNS_18ScopedObjectAccessEcNS_12JniValueTypeE+26)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#12 pc 000cb07f  /system/lib/libart.so (_ZN3art11ScopedCheck5CheckERNS_18ScopedObjectAccessEbPKcPNS_12JniValueTypeE+810)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#13 pc 000ce1d9  /system/lib/libart.so (_ZN3art8CheckJNI19GetMethodIDInternalEPKcP7_JNIEnvP7_jclassS2_S2_b+460)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#14 pc 000c402d  /system/lib/libart.so (_ZN3art8CheckJNI11GetMethodIDEP7_JNIEnvP7_jclassPKcS6_+24)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#15 pc 0031d1f9  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN3Env12getClassNameEP7_jclass+304)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#16 pc 0030ebcd  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN12CJavaContext11ConstructorERKN2v820FunctionCallbackInfoINS0_5ValueEEE+320)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#17 pc 007d470c  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN2v88internal25FunctionCallbackArguments4CallEPFvRKNS_20FunctionCallbackInfoINS_5ValueEEEE+188)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#18 pc 00810c5c  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#19 pc 008113f8  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#20 pc 008117fc  /data/app/com.samsung.smcl.vr.gvrf_launcher-1/lib/arm/libjav8.so (_ZN2v88internal21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE+72)
11-06 16:37:31.371 10781 10781 F DEBUG   :     Samsung#21 pc 00000098  <anonymous:cbc06000>
@xcaostagit xcaostagit mentioned this pull request Nov 28, 2017
Closed
@NolaDonato NolaDonato mentioned this pull request Feb 14, 2018
Merged
@mwitchwilliams mwitchwilliams mentioned this pull request May 29, 2018
Merged
@serarmatloob serarmatloob mentioned this pull request Jun 13, 2018
Closed
liaxim pushed a commit to liaxim/GearVRf that referenced this pull request Nov 13, 2018
@asg024
Merge pull request Samsung#4 from sxrsdk/master
90696bf 
sync latest from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonShemitz @chenchao1407