Skip to content
This repository has been archived by the owner on Apr 27, 2020. It is now read-only.

Commit

Permalink
helper apps stuff all moved to helpers-stuff dir, exposed node-red da…
Browse files Browse the repository at this point in the history
…ta/config, dropped including Dockerfiles
  • Loading branch information
milutz committed Jun 1, 2017
1 parent 3382205 commit 44fb3d9
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 16 deletions.
14 changes: 8 additions & 6 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,29 +13,31 @@ services:
- elasticsearch
- node-red
node-red:
image: nodered/node-red-docker
image: nodered/node-red-docker:${NODERED_VERSION}

This comment has been minimized.

Copy link
@wrathagom

wrathagom Jun 2, 2017

Contributor

@milutz does the lack of a default on the node-red library mean that if nothing is specified it will default to pulling latest? Or will it fail without anything being specified?

This comment has been minimized.

Copy link
@milutz

milutz Jun 2, 2017

Author Contributor

Ok, the comment was up here - not sure why I missed it when I was looking before - odd.

ports: ['1880:1880']
volumes:
- ${NODERED_CONFIG:-./helpers-stuff/node-red}:/data
networks: ['ingest-net']
elasticsearch:
build: elasticsearch/
image: docker.elastic.co/elasticsearch/elasticsearch:${ELASTIC_VERSION:-5.4.0}
environment:
- "ES_JAVA_OPTS=-Xmx1g -Xms1g"
ports: ['9200:9200']
networks: ['ingest-net']
volumes:
- ./elasticsearch/config/elasticsearch.yml:/usr/share/elasticsearch/config/elasticsearch.yml
- ${ES_DATA:-./es-data}:/usr/share/elasticsearch/data
- ${ES_CONFIG:-./helpers-stuff/elasticsearch.yml}:/usr/share/elasticsearch/config/elasticsearch.yml
- ${ES_DATA:-./helpers-stuff/es-data}:/usr/share/elasticsearch/data
healthcheck:
test: ['CMD', 'curl', '-f', '-u', '${ES_USER:-elastic}:${ES_PASSWORD:-changeme}', 'http://localhost:9200']
interval: 1m30s
timeout: 10s
retries: 3
kibana:
build: kibana/
image: docker.elastic.co/kibana/kibana:${ELASTIC_VERSION:-5.4.0}
ports: ['5601:5601']
networks: ['ingest-net']
volumes:
- ./kibana/config/:/usr/share/kibana/config
- ${KIBANA_CONFIG:-./helpers-stuff/kibana.yml}:/usr/share/kibana/config/kibana.yml
depends_on:
- elasticsearch
healthcheck:
Expand Down
4 changes: 0 additions & 4 deletions elasticsearch/Dockerfile

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 4 additions & 0 deletions helpers-stuff/node-red/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Ignore everything in this directory
*
# Except this file
!.gitignore
5 changes: 0 additions & 5 deletions kibana/Dockerfile

This file was deleted.

1 change: 0 additions & 1 deletion node-red/Dockerfile

This file was deleted.

5 comments on commit 44fb3d9

@milutz
Copy link
Contributor Author

@milutz milutz commented on 44fb3d9 Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wrathagom ...wierd... while I got the email for you comment, I can't see to see it in GitHub...

... it should have a default. Booboo on my part, will fix now

@wrathagom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually inline in the code difference section...

@milutz
Copy link
Contributor Author

@milutz milutz commented on 44fb3d9 Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think so - see new commit, default added

@wrathagom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I meant my comment was inline... send you a screenshot in slack

@milutz
Copy link
Contributor Author

@milutz milutz commented on 44fb3d9 Jun 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL - ok - yes, just figured that out :)

Please sign in to comment.