Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front-end Javascript error in Firefox, when attempting to 'Join' #94

Open
allanderek opened this issue Aug 29, 2023 · 5 comments
Open
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@allanderek
Copy link

I get an error if I attempt to join in Firefox:
image

@samternent
Copy link
Owner

Thanks for reporting this. I'll take a look this evening

@samternent
Copy link
Owner

samternent commented Aug 29, 2023

Thanks again for reporting this one @allanderek .

The issue is due to a newer build being released during your session, so the hashes of the route files, which are used for caching, have changed. A detailed explanation can be found on this SO thread.

The current fix for this is to refresh the page, which is less than ideal.

As the routes are currently quite lightweight, I've made a change in the bundling strategy to bundle more routes together which will hopefully mitigate this.

In the longer term, I have a task in the backlog to utilise my service worker and indicate when a newer version of the app is available or the app requires a refresh.

@allanderek
Copy link
Author

Okay, I created an account with a different browser. I still cannot login with Firefox though:
image

This is likely something to do with CORS:
image

As I say I've logged in with a different browser, so it's not a major issue for me.

@samternent
Copy link
Owner

samternent commented Aug 31, 2023

thanks, @allanderek - I'll re-open this and take a look.
You've caught me out not doing cross-browser testing 😄 🙏🏻

@samternent samternent reopened this Aug 31, 2023
@allanderek
Copy link
Author

Very understandable ;)

@samternent samternent self-assigned this May 22, 2024
@samternent samternent added bug Something isn't working help wanted Extra attention is needed labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants