Rework dockerization #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under California law, all project contributions committed by me are copyright Google. This does not affect the license my patches are available under (Apache 2 / MIT), nor does it affect the contributions of any other individuals. This only applies for contributions I author while employed at Google. This does not grant Google the right to revoke my contributions from the project in the future.
This Dockerfile describes a multi-stage build that downloads a Racket prerelease Linux installer script and runs it in “in place” mode, resulting in a Docker image with `racket`, `raco`, `scribble`, etc. available from the command line. Build arguments allow customizing the base image used as well as the specific installer variant downloaded. Unix-style installs are not included yet due to difficulty in ensuring the installer itself is not included in the final image’s layers.
This Dockerfile installs the packages needed to run all non-GUI release tests. Running a release tester container executes those tests. Individual test commands are placed in a `test.sh` script, but ideally all of these tests would run with a single `raco test` command. Some non-GUI release tests still need adaptation to run properly in a container.
Doesn’t work yet. Requires a properly containerized xvfb server and installing several GUI-related foreign libraries.
These tests currently fail and need to be fixed in some way. Reasons for failure include known bugs and issues running inside a container, among other things.
The Racket installer and release tester dockerfiles download all the files they need from remote sources (except for the test scripts), so we use an “opt-in” rather than an “opt-out” ignore configuration. Note that Dockerfiles themselves must be included in the build context.
This tests four variants of a prerelease installer: one for each combination of a full or minimal distribution for either the x86_64 or i386 platforms. For each variant, the test verifies that: - An in-place install completes successfully - Racket code can be evaluated - Packages can be installed over HTTPS - The working non-GUI tests pass Tests still need to be included for the following: - Unix-style installations - Generated uninstall scripts - From-source builds, both with and without pre-built packages - GUI tests - `linux-natipkg` installers (which seem to have OpenSSL issues) Unfortunately, `docker-compose up —build` doesn’t work as nicely as it should because that runs tests in parallel, resulting in four parallel runs of the intensely memory-hungry database tests. Results in termination of containers with extreme prejudice.
samth
approved these changes
Nov 1, 2017
Dockerfile.test
Outdated
|
|
||
| FROM ${RACKET_IMAGE} | ||
|
|
||
| RUN raco pkg install --auto --installation \ |
There was a problem hiding this comment.
I think we should just install main-distribution-test instead of most of these.
|
Actually, can you also fix the readme so that I know what to run? |
|
Ok, there are a few things missing from this:
I think that's it that this misses from the code I've written. |
It appears that the `distro-build-test` package isn’t included in the main distribution or its tests.
|
Would you prefer we add those cases before merging this PR or after? |
|
We can merge this PR first. There's a while before the next release cycle. |
|
I think we can merge this, and start working on further improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how Docker is used to be more in line with Docker's philosophical assumptions and best practices. More pragmatically, it's now much easier to run the release tests for every installer variant, not just one. In-depth change descriptions can be found in each commit message.
Closes #2
Closes #3 (I think)
Closes #4
Closes #5
Closes #8
Closes #9
Closes #11
Closes #14
Copyright Google, see first commit for details.