Add core Racket tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures tests run as the racket user can modify racket directories like the package and collection installation directories.
They’re still run as separate services in docker-compose, but now the same Dockerfile and image is used (just with different commands). This lets use use the USER instruction to set the user to `racket` instead of `root` without messing up installation of GUI packages with `apt-get`. Also adds a YAML anchor for the GUI test service to make the configuration a little less repetitive.
samth
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31.
The reason this wasn’t working before is because some of the tests run by
tests/racket/testassumed they wouldn’t be run as the root user, leading to problems when run in Docker. Creating aracketuser in the testing images and adding a USER instruction to run the tests under that user solves the problem.