You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is related to #455, but we also need to add tests to verify this in general. Specifically, we need to ensure that the NM tag is regenerated using the same algorithm used by Picard. It looks like the CRAM code is using SequenceUtils.calculateMdAndNmTags (with restoreMD set to false), whereas it looks like Picard is using SequenceUtils.calculateSamNmTag. Need to verify this.
The text was updated successfully, but these errors were encountered:
@yfarjoun Do you have more context for this SamFormatConverter issue ? It looks to me like Picard is just delegating to htsjdk to do the conversion, so (with the changes we made in #487) it should be restoring whatever NM tag value was there when the file was originally converted to CRAM.
#499 (unsigned attributes) #713 (cigar element transformations) #714 (lossy values for unmapped reads) #509 (legacy issue that only affects version 2.1 CRAMs created with old htsjdk code)
This is related to #455, but we also need to add tests to verify this in general. Specifically, we need to ensure that the NM tag is regenerated using the same algorithm used by Picard. It looks like the CRAM code is using SequenceUtils.calculateMdAndNmTags (with restoreMD set to false), whereas it looks like Picard is using SequenceUtils.calculateSamNmTag. Need to verify this.
The text was updated successfully, but these errors were encountered: