Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinningIndexBuilder assumes no feature can be at offset 0 #943

Closed
cmnbroad opened this issue Jul 24, 2017 · 4 comments
Closed

BinningIndexBuilder assumes no feature can be at offset 0 #943

cmnbroad opened this issue Jul 24, 2017 · 4 comments
Assignees

Comments

@cmnbroad
Copy link
Collaborator

For feature files with no header (like a BED file, which may have no header), 0 is a legitimate offset, even if the file is block gzipped and the offset represents a virtual file offset. However, the binning indexer always sets the window for a bin to the lowest feature offset for that bin that is not 0. i.e., BED files can have the first feature at offset 0.

Fixed in #906.

@cmnbroad cmnbroad self-assigned this Jul 24, 2017
@cmnbroad
Copy link
Collaborator Author

A example where this issue manifests is in #820.

@magicDGS
Copy link
Member

Dup of #393?

@cmnbroad
Copy link
Collaborator Author

@magicDGS I created this ticket so we could track the BinningIndexBuilder part of the issue separately from the .gz part. So there is some overlap, but not exactly a dup.

@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Aug 9, 2017

Fixed via #906.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants