Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRLF line termination not handled properly in sam_parse_worker #1148

Closed
anderskaplan opened this issue Sep 29, 2020 · 1 comment
Closed

CRLF line termination not handled properly in sam_parse_worker #1148

anderskaplan opened this issue Sep 29, 2020 · 1 comment

Comments

@anderskaplan
Copy link
Contributor

To reproduce: unix2dos test/index.sam, then run the test suite.

Actual: The test test_index fails, but only in the multi-threaded case. The single-threaded case passes.
This is because the line parser in sam_parse_worker does not handle CRLF line endings properly. The CR is passed on to sam_parse1 where it is included in the aux field data. The resulting BAM differs from the reference.

Expected: The test suite should pass regardless of line endings.

@whitwham
Copy link
Contributor

whitwham commented Oct 8, 2020

Fixed in #1149.

@whitwham whitwham closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants