Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug: Incorrect decrypted file name for duplicated files when in the same location. #28

Closed
sh-dv opened this issue Sep 10, 2021 · 1 comment 路 Fixed by #29
Closed

馃悰 Bug: Incorrect decrypted file name for duplicated files when in the same location. #28

sh-dv opened this issue Sep 10, 2021 · 1 comment 路 Fixed by #29
Assignees
@samuel-lucas6
Labels
bug Houston, we've got a problem

Comments

@sh-dv
Copy link
Contributor

sh-dv commented Sep 10, 2021 •
edited

Description

Situation : I have a file called Document.txt, i encrypt this file and have the new file named Document.txt.kryptor, then I encrypt the same Document.txt file and get another encrypted file called Document.txt (2).kryptor. When trying to decrypt the second file Document.txt (2).kryptor everything works except the new decrypted file is called Document.txt (2). this file won't open unless you rename it (remove brackets) to Document.txt.

This situation only happens when there is already another file having the same name.

Platform Info

  • OS: Windows
  • Version: 3.0.3
@sh-dv sh-dv added the bug Houston, we've got a problem label Sep 10, 2021
@sh-dv sh-dv mentioned this issue Sep 10, 2021
Merged
@sh-dv sh-dv changed the title 馃悰 Bug Report: Decrypted filename on duplicated files in the same location. 馃悰 Bug Report: Incorrect decrypted file name for duplicated files when in the same location. Sep 10, 2021
@samuel-lucas6
Copy link
Owner

Hi @sh-dv,

Thanks for the great find! This unique rename implementation has been a bit of a hassle. I'll take a look at your pull request.

@samuel-lucas6 samuel-lucas6 linked a pull request Sep 11, 2021 that will close this issue
FileDecryption.cs: Solves issue #28. #29
Merged
samuel-lucas6 pushed a commit that referenced this issue Sep 12, 2021
@sh-dv
FileDecryption.cs: Fix issue #28.
03bee33 
Fixes issue #28. Also, make it clear that the file and directory number variables start at 2.
@samuel-lucas6 samuel-lucas6 changed the title 馃悰 Bug Report: Incorrect decrypted file name for duplicated files when in the same location. 馃悰 Bug: Incorrect decrypted file name for duplicated files when in the same location. Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samuel-lucas6 samuel-lucas6

Labels
bug Houston, we've got a problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FileDecryption.cs: Solves issue #28.
2 participants
@sh-dv @samuel-lucas6