generate Generate methods for enums (compatible with testing/quick) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As this seems only useful for testing could be put behind a flag (defaulted to false). Does that seem reasonable? |
|
Part of my worry is that it makes generated code depend on reflect |
|
Yup, that sounds totally reasonable. I'll update the diff.
|
|
Would there be any benefit to generating these functions in a separate companion file (e.g. |
nuance
force-pushed
the
enum_generate_methods
branch
from
3f52a50
to
2631e8f
Compare
|
Oops, forgot to actually push my changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More testing/quick support