This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
Fix test that was not properly shutting down server. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please close this pull request, I will resubmit each change individually. |
…ection of Zookeeper jar file. (#1)
… new op and error code. (#2) Implement Create2 as a separate call since it is not backward comptable.
* Add basic support for read-only mode. Backporting my internal tests will require refactoring the existing test code quite a bit. * Fix accidental merge-revert. * Fix basic tests.
…ow buffers to be resized for testing purposes. Improve debug logging to track session. (#4)
This behavior allows clients to become aware about session state in race-free way.
Summary: Fix the race condition when: 1. TCP connection is established successfully 2. Initial auth procudure to establish session succeeds 3. Re-auth fails Currently client is stuck forever waiting for the response from a server, fix it by adding proper error handling to resendZkAuth function & selecting between closeSend & resp channels
samuel
force-pushed
the
master
branch
2 times, most recently
from
e51ba65
to
471cd4e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow direct injection of Zookeeper jar file.
This was causing subsequent tests to hang/fail.