Skip to content

Commit

Permalink
Django 1.3-izing everything. Moving logging back to counting everythi…
Browse files Browse the repository at this point in the history
…ng in the last day, but without the hard-work of deleting old entries.
  • Loading branch information
samuelclay committed May 1, 2011
1 parent 6d04024 commit f8583ad
Show file tree
Hide file tree
Showing 6 changed files with 52 additions and 20 deletions.
32 changes: 16 additions & 16 deletions apps/rss_feeds/models.py
Expand Up @@ -255,17 +255,17 @@ def save_feed_history(self, status_code, message, exception=None):
message=message,
exception=exception,
fetch_date=datetime.datetime.utcnow()).save()
day_ago = datetime.datetime.now() - datetime.timedelta(hours=24)
new_fetch_histories = MFeedFetchHistory.objects(feed_id=self.pk, fetch_date__gte=day_ago)
if new_fetch_histories.count() < 5 or True:
old_fetch_histories = MFeedFetchHistory.objects(feed_id=self.pk)[5:]
else:
old_fetch_histories = MFeedFetchHistory.objects(feed_id=self.pk, fetch_date__lte=day_ago)
for history in old_fetch_histories:
history.delete()
# day_ago = datetime.datetime.now() - datetime.timedelta(hours=24)
# new_fetch_histories = MFeedFetchHistory.objects(feed_id=self.pk, fetch_date__gte=day_ago)
# if new_fetch_histories.count() < 5 or True:
# old_fetch_histories = MFeedFetchHistory.objects(feed_id=self.pk)[5:]
# else:
# old_fetch_histories = MFeedFetchHistory.objects(feed_id=self.pk, fetch_date__lte=day_ago)
# for history in old_fetch_histories:
# history.delete()
if status_code not in (200, 304):
fetch_history = map(lambda h: h.status_code,
MFeedFetchHistory.objects(feed_id=self.pk))
MFeedFetchHistory.objects(feed_id=self.pk)[:10])
self.count_errors_in_history(fetch_history, status_code, 'feed')
elif self.has_feed_exception:
self.has_feed_exception = False
Expand All @@ -278,13 +278,13 @@ def save_page_history(self, status_code, message, exception=None):
message=message,
exception=exception,
fetch_date=datetime.datetime.utcnow()).save()
old_fetch_histories = MPageFetchHistory.objects(feed_id=self.pk).order_by('-fetch_date')[5:]
for history in old_fetch_histories:
history.delete()
# old_fetch_histories = MPageFetchHistory.objects(feed_id=self.pk).order_by('-fetch_date')[5:]
# for history in old_fetch_histories:
# history.delete()

if status_code not in (200, 304):
fetch_history = map(lambda h: h.status_code,
MPageFetchHistory.objects(feed_id=self.pk))
MPageFetchHistory.objects(feed_id=self.pk)[:10])
self.count_errors_in_history(fetch_history, status_code, 'page')
elif self.has_page_exception:
self.has_page_exception = False
Expand Down Expand Up @@ -1070,7 +1070,7 @@ class MFeedFetchHistory(mongo.Document):
'collection': 'feed_fetch_history',
'allow_inheritance': False,
'ordering': ['-fetch_date'],
'indexes': [('fetch_date', 'status_code'), ('feed_id', 'status_code'), ('feed_id', 'fetch_date')],
'indexes': [('fetch_date', 'status_code'), ('feed_id', 'status_code'), ('feed_id', '-fetch_date')],
}

def save(self, *args, **kwargs):
Expand All @@ -1080,7 +1080,7 @@ def save(self, *args, **kwargs):

@classmethod
def feed_history(cls, feed_id):
fetches = cls.objects(feed_id=feed_id).order_by('-fetch_date')
fetches = cls.objects(feed_id=feed_id).order_by('-fetch_date')[:5]
fetch_history = []
for fetch in fetches:
history = {}
Expand Down Expand Up @@ -1113,7 +1113,7 @@ def save(self, *args, **kwargs):

@classmethod
def feed_history(cls, feed_id):
fetches = cls.objects(feed_id=feed_id).order_by('-fetch_date')
fetches = cls.objects(feed_id=feed_id).order_by('-fetch_date')[:5]
fetch_history = []
for fetch in fetches:
history = {}
Expand Down
9 changes: 8 additions & 1 deletion apps/statistics/models.py
@@ -1,7 +1,7 @@
import datetime
import mongoengine as mongo
from django.db.models import Avg, Count
from apps.rss_feeds.models import MFeedFetchHistory, FeedLoadtime
from apps.rss_feeds.models import MFeedFetchHistory, MPageFetchHistory, FeedLoadtime
from apps.profile.models import Profile
from utils import json_functions as json

Expand Down Expand Up @@ -49,6 +49,13 @@ def collect_statistics_feeds_fetched(cls, last_day=None):
feeds_fetched = MFeedFetchHistory.objects(fetch_date__gte=last_day).count()
cls.objects(key='feeds_fetched').update_one(upsert=True, key='feeds_fetched', value=feeds_fetched)

old_fetch_histories = MFeedFetchHistory.objects(fetch_date__lte=last_day)
for history in old_fetch_histories:
history.delete()
old_page_histories = MPageFetchHistory.objects(fetch_date__lte=last_day)
for history in old_page_histories:
history.delete()

return feeds_fetched

@classmethod
Expand Down
25 changes: 25 additions & 0 deletions media/js/newsblur/reader_preferences.js
Expand Up @@ -280,6 +280,25 @@ NEWSBLUR.ReaderPreferences.prototype = {
'Feed view styling'
])
]),
$.make('div', { className: 'NB-preference NB-preference-tooltips' }, [
$.make('div', { className: 'NB-preference-options' }, [
$.make('div', [
$.make('input', { id: 'NB-preference-tooltips-1', type: 'radio', name: 'show_tooltips', value: 1 }),
$.make('label', { 'for': 'NB-preference-tooltips-1' }, [
'Show tooltips'
])
]),
$.make('div', [
$.make('input', { id: 'NB-preference-tooltips-2', type: 'radio', name: 'show_tooltips', value: 0 }),
$.make('label', { 'for': 'NB-preference-tooltips-2' }, [
'Don\'t bother showing tooltips.'
])
])
]),
$.make('div', { className: 'NB-preference-label'}, [
'Tooltips'
])
]),
$.make('div', { className: 'NB-preference NB-preference-story-share' }, [
$.make('div', { className: 'NB-preference-options' }, [
$.make('div', { className: 'NB-preference-option', title: 'Twitter' }, [
Expand Down Expand Up @@ -419,6 +438,12 @@ NEWSBLUR.ReaderPreferences.prototype = {
return false;
}
});
$('input[name=show_tooltips]', this.$modal).each(function() {
if ($(this).val() == NEWSBLUR.Preferences.show_tooltips) {
$(this).attr('checked', true);
return false;
}
});
$('input[name=story_styling]', this.$modal).each(function() {
if ($(this).val() == NEWSBLUR.Preferences.story_styling) {
$(this).attr('checked', true);
Expand Down
3 changes: 1 addition & 2 deletions settings.py
Expand Up @@ -63,8 +63,7 @@

TEMPLATE_LOADERS = (
'django.template.loaders.filesystem.Loader',
'django.template.loaders.app_directories.load_template_source',
'django.template.loaders.eggs.load_template_source',
'django.template.loaders.app_directories.Loader',
)
TEMPLATE_CONTEXT_PROCESSORS = (
"django.contrib.auth.context_processors.auth",
Expand Down
1 change: 1 addition & 0 deletions templates/base.html
Expand Up @@ -28,6 +28,7 @@
'new_window' : 1,
'default_view' : 'page',
'hide_read_feeds' : 0,
'show_tooltips' : 1,
'feed_order' : 'ALPHABETICAL',
'hide_story_changes' : 0,
'feed_view_single_story' : 0,
Expand Down
2 changes: 1 addition & 1 deletion utils/log.py
Expand Up @@ -18,7 +18,7 @@ def getlogger():
hdlr.setFormatter(formatter)
logger.addHandler(hdlr)
logger.setLevel(settings.LOG_LEVEL)

return logger

def user(u, msg):
Expand Down

0 comments on commit f8583ad

Please sign in to comment.