Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Images are still downloaded after stories marked as read #677

Closed
samuelclay opened this issue Mar 19, 2015 · 3 comments
Closed

Comments

@samuelclay
Copy link
Owner

See https://getsatisfaction.com/newsblur/topics/android-busy-storing-images-even-after-everything-is-marked-as-read. Not too important to do, but if this is a quick 2 minute fix, then by all means.

@dosiecki
Copy link
Contributor

Yeah, if you can somehow read more quickly than the images can be fetched, it is possible to out-pace the background process.

Right now we just keep a queue of image URLs that need to be fetched. If we wanted to double-check that a story didn't get read in the moments between enqueue and fetch, we could query the DB and re-check read status. I think the image prefetch thread runs at a low enough priority that it shouldn't slow things down too much. I will give it a whirl.

@dosiecki
Copy link
Contributor

It is a bit expensive to re-check that the stories associated with a given image are still unread before each and every image, but I added some logic to check in batches. This should interrupt all but the first few fetches after marking something read.

@samuelclay
Copy link
Owner Author

Awesome, I let the user know on GS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants