Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Dependency On Heroku's Docker Image #36

Merged
merged 10 commits into from
Apr 6, 2017

Conversation

tompurl
Copy link

@tompurl tompurl commented Mar 31, 2017

This is related to issues #34 and #35.

I and others were not able to build the dev environment using the Heroku Docker image. When I looked into it I found that we would have to either use a very old version of the parser library or hack the Heroku Docker image, both of which sounded unmaintainable.

I therefore did the following:

  • Made code and doc changes that make it possible to build a dev environment with "plain-old" Docker.
  • Made doc changes that tell the user that the code base can be developed using a non-Docker-based rails setup.
  • Made doc changes that show developers how to push code to a "prod" environment without using Heroku's Docker image.

Copy link
Owner

@samuelcole samuelcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

excellent documentation!

@samuelcole samuelcole merged commit 81a6d65 into samuelcole:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants