Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor all asserts into raise <exception>, close #371 #379

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

JonasKs
Copy link
Sponsor Collaborator

@JonasKs JonasKs commented Dec 15, 2022

Close #371

Can be closed if #371 is not accepted.

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #379 (9876733) into main (e0cd916) will decrease coverage by 1.88%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   98.66%   96.79%   -1.88%     
==========================================
  Files          11       11              
  Lines        1052     1062      +10     
  Branches      199      208       +9     
==========================================
- Hits         1038     1028      -10     
- Misses          6       16      +10     
- Partials        8       18      +10     
Impacted Files Coverage Δ
arq/connections.py 90.00% <0.00%> (-5.21%) ⬇️
arq/cron.py 93.25% <0.00%> (-6.75%) ⬇️
arq/worker.py 97.93% <0.00%> (-1.24%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cd916...9876733. Read the comment docs.

@WillemDeGroef
Copy link

Why is this PR not accepted?

@samuelcolvin
Copy link
Owner

Why is this PR not accepted?

Because I've been very busy. My mistake.

I think we should use ValueError or TypeError for many of these as they're the wrong value or the wrong type.

@JonasKs
Copy link
Sponsor Collaborator Author

JonasKs commented Feb 3, 2024

Cheers Samuel, I'll look over the errors when I find time. Probably next week or so, I'm gone for a work trip.

If you want to fork my fork and contribute fixes to it, you're welcome to do so @WillemDeGroef.

@samuelcolvin samuelcolvin merged commit 5769e10 into samuelcolvin:main Apr 1, 2024
@samuelcolvin
Copy link
Owner

v0.26.0b1 is released, please try it, I'll release v0.26 at the end of the week, see #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be cool to get rid of assert in production code
3 participants