New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests #2
Unit tests #2
Conversation
Hi really happy to get this to a point where it can be released to pypi, including unit tests. I would prefer not to use tox, but rather rely on github actions to test on multiple versions - this is mostly because it's the workflow I know best and can therefore support most easily. Could you refactor this to follow the example of dirty_equals? If there are bits you find confusing, feel free to leave a comment on this PR and omit them. |
I removed tox and adapted the GHA yaml config file following what I could read in dirty_equal. I am curious how do you test several python versions on your development machine without tox? At first I intended to plug pre-commit and some style tools like black, but I thought this would be better in another PR. |
I have multiple virtualenvs, and if I really need to test between versions quickly, I activate each in a different terminal; but mostly it's not necessary.
Sounds good. |
- Added a DNSServer class in dnserver.py - Added a simple unit test - Added a GHA configuration
@@ -0,0 +1,62 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what this is doing, but I think it shouldn't be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yamllint yells when this is absent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge and check what github thinks, it definitely doesn't have to be there.
thanks so much, I'll make further changes in a new PR. |
This patch:
DNSServer
class indnserver.py
. It has a simple interface likeserver.start()
,server.stop()
andserver.is_running
. I hope this can be used as a dns server fixture in other projects.0.9.20
@samuelcolvin