New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Gift Aid tick box more obvious #298
Make Gift Aid tick box more obvious #298
Conversation
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 35 35
Lines 3326 3326
Branches 386 386
=======================================
Hits 3236 3236
Misses 47 47
Partials 43 43 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks good.
|
||
<hr/> | ||
|
||
<strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need strong
here as well as b
above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrap adds an element with a 'text-muted' class around the label text. Another css class would be needed to override and this was cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix #279