Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gift Aid tick box more obvious #298

Merged
merged 1 commit into from Oct 8, 2020

Conversation

pro-Nate
Copy link
Collaborator

@pro-Nate pro-Nate commented Oct 2, 2020

fix #279

@pro-Nate pro-Nate changed the title Update PaymentForm.js and Stripe.js fix #279 Make Gift Aid tick box more obvious, fix #279 Oct 2, 2020
@pro-Nate pro-Nate linked an issue Oct 2, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          35       35           
  Lines        3326     3326           
  Branches      386      386           
=======================================
  Hits         3236     3236           
  Misses         47       47           
  Partials       43       43           

Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looks good.


<hr/>

<strong>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need strong here as well as b above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap adds an element with a 'text-muted' class around the label text. Another css class would be needed to override and this was cleaner.

@samuelcolvin samuelcolvin changed the title Make Gift Aid tick box more obvious, fix #279 Make Gift Aid tick box more obvious Oct 8, 2020
Copy link
Owner

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pro-Nate pro-Nate merged commit 4648ac9 into master Oct 8, 2020
@pro-Nate pro-Nate deleted the Issue#279_-_Make_Gift_Aid_tick_box_more_obvious branch October 8, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Gift Aid tick box more obvious
2 participants