Let SecretStrs be value equals #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
======================================
Coverage 100% 100%
======================================
Files 20 20
Lines 3365 3369 +4
Branches 663 663
======================================
+ Hits 3365 3369 +4
Continue to review full report at Codecov.
|
sbv-trueenergy
changed the title
|
I couldnt find a place that needed documentation updating but correct me if I'm wrong |
samuelcolvin
reviewed
Dec 5, 2019
| @@ -1699,6 +1699,10 @@ class Foobar(BaseModel): | |||
| with pytest.warns(DeprecationWarning, match=r'`secret_str.display\(\)` is deprecated'): | |||
| assert f.empty_password.display() == '' | |||
|
|
|||
| # Assert that SecretStr is equal to SecretStr if the secret is the same. | |||
| assert f == f.copy() | |||
| assert f != f.copy(update=dict(password='4321')) | |||
There was a problem hiding this comment.
this is fine, but please add an explicit test, e.g.:
def test_secret_str():
assert SecretStr('123') == SecretStr('123')
assert SecretStr('123') != SecretStr('321')
assert SecretStr('123') != '123'
assert SecretStr('123') is not SecretStr('123')And the same for SecretBytes.
There was a problem hiding this comment.
I kept the copy version and added these below. Ok?
samuelcolvin
reviewed
Dec 5, 2019
|
thanks a lot. |
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
15 tasks
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
As discussed in the issue, this PR adds a
__eq__method for SecretStr that compares the secret value such that SecretStr('a') == SecretStr('a') and SecretStr('a') != SecretStr('b')Related issue number
#1078
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)