Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub actions #1326

Merged
merged 22 commits into from Mar 21, 2020
Merged

Move to GitHub actions #1326

merged 22 commits into from Mar 21, 2020

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Mar 19, 2020

Change Summary

Move all tests to run on github actions.

This combined and extends #1293 and #1304. Thank you very much @StephenBrown2 for your work on both, they were very helpful when working on this. I decided it was easiest to start a new PR to combined results, I hope you don't mind.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1326 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          21       21           
  Lines        3725     3725           
  Branches      736      736           
=======================================
  Hits         3721     3721           
  Misses          2        2           
  Partials        2        2           
Impacted Files Coverage Δ
pydantic/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b002e...09e45e6. Read the comment docs.

@StephenBrown2
Copy link
Contributor

Happy to do the legwork to get it started, I'd imagined they'd get combined in the end anyways.

@StephenBrown2
Copy link
Contributor

Not sure if it's relevant, but do you want to add or move to manylinux2014 wheels (vs manylinux2010) as well?
https://cibuildwheel.readthedocs.io/en/stable/options/#examples_4
https://www.python.org/dev/peps/pep-0599/#the-manylinux2014-policy

@samuelcolvin
Copy link
Member Author

done, now builds manylinux1 and manylinux2014 binaries. Hope that is correct.

@samuelcolvin samuelcolvin merged commit 96c9c40 into master Mar 21, 2020
@samuelcolvin samuelcolvin deleted the move-2-github-actions branch March 21, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants