Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation (#162) #189

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Conversation

Gr1N
Copy link
Contributor

@Gr1N Gr1N commented Jun 2, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jun 2, 2018

Codecov Report

Merging #189 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #189    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           9     10     +1     
  Lines        1036   1148   +112     
  Branches      214    214            
======================================
+ Hits         1036   1148   +112

@samuelcolvin
Copy link
Member

Looks good, except we need a bit of discussion of how errors work and how they can be displayed to end users.

@Gr1N
Copy link
Contributor Author

Gr1N commented Jun 3, 2018

@samuelcolvin updated, check please

@samuelcolvin
Copy link
Member

Looks good, I have some changes and improvements to the English, but that's probably better done in a separate PR.

@samuelcolvin samuelcolvin merged commit 3f53cb5 into pydantic:master Jun 4, 2018
@Gr1N Gr1N deleted the update-docs branch June 4, 2018 09:58
@Gr1N
Copy link
Contributor Author

Gr1N commented Jun 4, 2018

Thanks!

@samuelcolvin
Copy link
Member

#162

alexdrydew pushed a commit to alexdrydew/pydantic that referenced this pull request Dec 23, 2023
* "extra_schema" on positional tuples

* test any for extra_schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants