Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try speeding up ci using caching and rearranging jobs #3974

Merged
merged 12 commits into from
May 14, 2022
Merged

try speeding up ci using caching and rearranging jobs #3974

merged 12 commits into from
May 14, 2022

Conversation

samuelcolvin
Copy link
Member

Change Summary

Rearrange steps and using caching to try to speedup CI.

@samuelcolvin
Copy link
Member Author

samuelcolvin commented Apr 4, 2022 •
edited
Loading

@Zac-HD hypothesis seems to fail whenever the python cache is restored, everything else seems to be working fine here.

Any idea what's going on here? Would caching the .hypothesis directory help?

Update: the one weird passing case "test py3.7 on macos" is because that cache failed to save on the previous run.

@Zac-HD
Copy link
Contributor

Zac-HD commented Apr 4, 2022

Any idea what's going on here? Would caching the .hypothesis directory help?

I don't have any real idea what's going on here; so while I wouldn't expect caching the .hypothesis directory to help that might still be worth trying.

My best guess is that the new configuration isn't registering NameEmail, probably due to an import error. You can check this by inspecting the contents of the hypothesis.strategies._internal.types._global_type_lookup dict before and afterwards, and/or directly checking that you can import email_validator.

@samuelcolvin samuelcolvin marked this pull request as ready for review May 14, 2022 14:20
@samuelcolvin samuelcolvin merged commit 9baec86 into master May 14, 2022
@samuelcolvin samuelcolvin deleted the try-speedup-ci branch May 14, 2022 14:32
samuelcolvin added a commit that referenced this pull request May 14, 2022
@samuelcolvin
try speeding up ci using caching and rearranging jobs (#3974)
8855a25 
* try speeding up ci using caching and rearranging jobs

* fix job references

* cache lint and docs install

* tweak caching

* tweak caching to avoid conflicts

* correct use of runner.os

* bump

* stop skipping steps depending on cache

* prevent hypothesis flakeyness

* try skipping install steps again

* remove skipping install :-(
ntaylorwss pushed a commit to nicejobinc/pydantic that referenced this pull request Jun 24, 2022
@samuelcolvin
try speeding up ci using caching and rearranging jobs (pydantic#3974)
e02c863 
* try speeding up ci using caching and rearranging jobs

* fix job references

* cache lint and docs install

* tweak caching

* tweak caching to avoid conflicts

* correct use of runner.os

* bump

* stop skipping steps depending on cache

* prevent hypothesis flakeyness

* try skipping install steps again

* remove skipping install :-(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelcolvin @Zac-HD