-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG FIX: Use Path.relative_to()
for Python 3.8 compatibility
#150
Conversation
Path.relative_to()
for Python 3.8 compatibilityPath.relative_to()
for Python 3.8 compatibility
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 8 8
Lines 729 729
Branches 111 111
=======================================
Hits 702 702
Misses 21 21
Partials 6 6 Continue to review full report in Codecov by Sentry.
|
I believe the CI pipeline should be configured to lint on the minimal supported Python version to ensure backward compatibility, not on 3.10 as it is configured now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM, sorry for the slow review.
Shall I drop Python 3.7 support in a separate PR? @samuelcolvin |
I'm happy to drop 3.7 support. |
Thanks so much. |
You're welcome! devtools are awesome! 🚀 |
Thanks so much. |
.is_relative_to
is 3.9+. It causedpython -m devtools install
to fail in Python 3.8.https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.is_relative_to