Support serialization to "pretty" output #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, the CI build steps fail because of #12. |
|
this looks great. Please rebase to fix the errors and update the readme. |
|
Done. Is this what you had in mind regarding the README? |
|
great. I guess I'l release a new version. Is there anything you need? |
|
Excellent! I don't think I need anything else. |
|
deploying now. |
|
Thanks a lot. Works as expected! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Samuel, thanks for the nice library!
I found myself interested in "pretty" output because line-wrapped arrays make for more compact diffs of TOML under version control.
In the suggested implementation I have opted for a keyword argument in the Python layer to enable the new behavior on demand, but went with a separate function (unfortunately with a bit of code duplication) in Rust due to its lack of optional, default, and/or named arguments (as of mid-2020).
Note regarding the test cases: According to the documentation of
toml::ser::Serializer::pretty_string, the "pretty" output fortext = "\nfoo\nbar\n"should bebut I found it to be this instead (notice the blank line after the opening triple quotes):
Please let me know what you think and have a nice weekend!