Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support, drop Python 3.7 support #248

Merged
merged 3 commits into from Oct 13, 2023

Conversation

gi0baro
Copy link
Contributor

@gi0baro gi0baro commented Oct 13, 2023

Changes summary

  • Add Python 3.12 support
  • Drop Python 3.7 support
  • Bump PyO3 to 0.20
  • Add pypy3.10 wheels in CI

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #248 (b3fd20f) into main (eb0df3a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files           6        6           
  Lines         416      416           
  Branches       82       82           
=======================================
  Hits          414      414           
  Misses          1        1           
  Partials        1        1           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0df3a...b3fd20f. Read the comment docs.

@gi0baro gi0baro marked this pull request as ready for review October 13, 2023 10:53
@gi0baro
Copy link
Contributor Author

gi0baro commented Oct 13, 2023

@samuelcolvin I'm not sure why the failing test on linux (seems flaky?)..

Regarding everything else let me know your comments/objections :)

@samuelcolvin
Copy link
Owner

looks good to me, but I would say, given it's the same test failing every time, that there is something wrong.

@gi0baro
Copy link
Contributor Author

gi0baro commented Oct 13, 2023

@samuelcolvin yeah, the strange thing to me is that is passing only on stable rust and py 3.11.
Gonna experiment with this a bit locally, I'll update you.

@gi0baro
Copy link
Contributor Author

gi0baro commented Oct 13, 2023

@samuelcolvin probably it was the scanning of / taking too much time. I changed the test, see b3fd20f

@samuelcolvin samuelcolvin merged commit 6ea19ca into samuelcolvin:main Oct 13, 2023
39 checks passed
@samuelcolvin
Copy link
Owner

Awesome, thank you.

I'll do a release today.

@samuelcolvin samuelcolvin mentioned this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants