Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyO3 #267

Merged
merged 2 commits into from
May 6, 2024
Merged

Update PyO3 #267

merged 2 commits into from
May 6, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented May 5, 2024

Update PyO3 using cargo update.

This is the minimal change needed to address #261.

@mgorny
Copy link
Contributor Author

mgorny commented May 5, 2024

Sorry, no clue how to deal with these issues.

@mgorny
Copy link
Contributor Author

mgorny commented May 5, 2024

Hmm, I suppose this means that PyO3 doesn't support 2.5 year old Rust anymore.

@samuelcolvin
Copy link
Owner

Ye, we restrict the version to (I think) 1.76 in pydantic and no one has complained.

@samuelcolvin
Copy link
Owner

@davidhewitt would know more.

We should set the min version in cargo to whatever PyO3 supports.

@davidhewitt
Copy link

It's possible but you'll have to downgrade packages like once_cell to versions still compatible with 1.56

The next PyO3 release will support a minimum of 1.63

Update pinned PyO3 to 0.20.3, which remains API-compatible and fixes
issues with PowerPC.
@mgorny mgorny changed the title Update Rust dependencies Update PyO3 May 5, 2024
@mgorny
Copy link
Contributor Author

mgorny commented May 5, 2024

Ok, so apparently cargo update (at least in 1.56.0) doesn't support selecting newest correct versions automatically, so I've instead limited the change to updating PyO3 itself.

@gaby
Copy link

gaby commented May 5, 2024

I ran into the same issue, created a fork with dependabot enabled and it created over 15 Pull Requests. All of them are failing during ci / lint and ci / check.

https://github.com/gaby/watchfiles/pulls

One of the big ones is setup-python action, the one used in this repo is way beyond deprecated:

  • Bump actions/setup-python from 1 to 5

@gaby
Copy link

gaby commented May 5, 2024

@samuelcolvin samuelcolvin merged commit 26b005e into samuelcolvin:main May 6, 2024
38 checks passed
@samuelcolvin
Copy link
Owner

thanks so much, I'll make more changes in later PRs.

@mgorny
Copy link
Contributor Author

mgorny commented May 8, 2024

Thanks!

@mgorny mgorny deleted the cargo-deps branch May 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants