Skip to content

Commit

Permalink
An issue where a cooling setpoint higher than 50 was failing the temp…
Browse files Browse the repository at this point in the history
…late generation has been fixed (#363)

* An issue where a cooling setpoint higher than 50 was failing the template generation

* FIxes issue with Ventilation
  • Loading branch information
Samuel Letellier-Duchesne committed Aug 4, 2022
1 parent b70ebac commit d15951d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions archetypal/template/conditioning.py
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def CoolingSetpoint(self, value):
assert (
self._heating_setpoint < value
), "Heating setpoint must be lower than the cooling setpoint."
self._cooling_setpoint = validators.float(value, minimum=-100, maximum=50)
self._cooling_setpoint = validators.float(value, minimum=-100, maximum=100)

@property
def HeatingSetpoint(self):
Expand All @@ -319,7 +319,7 @@ def HeatingSetpoint(self, value):
assert (
value < self._cooling_setpoint
), "Heating setpoint must be lower than the cooling setpoint."
self._heating_setpoint = validators.float(value)
self._heating_setpoint = validators.float(value, minimum=-100, maximum=100)

@property
def MaxCoolFlow(self):
Expand Down
4 changes: 2 additions & 2 deletions archetypal/template/ventilation.py
Original file line number Diff line number Diff line change
Expand Up @@ -1209,8 +1209,8 @@ def nominal_ventilation_aggregation(x):
aggregated accordingly.
"""
how_dict = {
"Archetype": x["Archetype"][0],
"Zone Name": x["Zone Name"][0],
"Archetype": x["Archetype"].iloc[0],
"Zone Name": x["Zone Name"].iloc[0],
"Name": top(x["Name"], x, "Zone Floor Area {m2}"),
"Schedule Name": top(x["Schedule Name"], x, "Zone Floor Area {m2}"),
"Fan Type {Exhaust;Intake;Natural}": top(
Expand Down

0 comments on commit d15951d

Please sign in to comment.