Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alternative installation instruction #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Zhomart
Copy link

@Zhomart Zhomart commented May 15, 2017

This method might be convenient. And this instruction will be helpful to new developers.

@@ -10,6 +10,8 @@ Build/Runs your crystal application, watches files, and rebuilds/reruns app on f

## Installation

### Installation using ruby script
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd opt to rename this from Installation using ruby script to Quick Installation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samueleaton Please change if needed, as English is not my native language, I might use some cumbersome words to describe things.

@samueleaton
Copy link
Owner

Thanks for this!

Does shards have an option for running a post-install script? I know that was in discussion before but am not sure if it has been implemented.

If thats the case, I would rather that tractive is compiled automatically and placed in the bin directory with the user having to manually place some command in a makefile

@Zhomart
Copy link
Author

Zhomart commented May 17, 2017

What do you think if I change all ./sentry [options] examples to ./bin/sentry [options]?

I think binaries should be in ./bin/ directory.

@samueleaton
Copy link
Owner

Can you share some examples of other crystal projects or guides where it is common to store binaries in a [project name]/bin directory?

@Zhomart
Copy link
Author

Zhomart commented May 22, 2017

The official shards library puts binaries in ./bin/ folder. https://github.com/crystal-lang/shards/blob/master/SPEC.md#targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants