prevent non-english chars are encoded. Fixes #50 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe removing encoding will fix #68 as well.. |
|
Would it be required to add an utf8-to-unicode conversion for the titles? |
|
Sofar my samples are displayed fine by the js tree. So i think additional conversion is not required. |
samuelet
added a commit
that referenced
this pull request
Jul 31, 2014
prevent non-english chars are encoded. Fixes #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idfilter()is applied atnsandhnswhich are already cleaned bycleanID()idfilter()is applied atidandhnsof items that are page ids as existing at file system.For all these cases no encoding is required.
In dTree.prototype.addNode in indexmenu.js these id's are compared with the page id from $JSINFO
https://github.com/samuelet/indexmenu/blob/master/scripts/indexmenu.js#L205
I think it is not useful to keep the encoding (and solve this issue with decoding in dTree.prototype.add)
@samuelet can you review this and merge if it is fine?
Added some escaping as well.