Made renderer classes readonly [SLE-192]

samuelgfeller · Jan 19, 2024 · 4da78a1 · 4da78a1
1 parent 2e67e07
commit 4da78a1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 17 deletions.
diff --git a/src/Application/Renderer/JsonEncoder.php b/src/Application/Renderer/JsonEncoder.php
@@ -4,14 +4,11 @@
 
 use Psr\Http\Message\ResponseInterface;
 
-class JsonEncoder
+readonly class JsonEncoder
 {
     /**
      * Write JSON to the response body.
      *
-     * This method prepares the response object to return an HTTP JSON
-     * response to the client.
-     *
      * @param ResponseInterface $response The response
      * @param mixed $data The data
      * @param int $status

diff --git a/src/Application/Renderer/RedirectHandler.php b/src/Application/Renderer/RedirectHandler.php
@@ -5,18 +5,11 @@
 use Psr\Http\Message\ResponseInterface;
 use Slim\Interfaces\RouteParserInterface;
 
-class RedirectHandler
+readonly class RedirectHandler
 {
-    private RouteParserInterface $routeParser;
 
-    /**
-     * The constructor.
-     *
-     * @param RouteParserInterface $routeParser The route parser
-     */
-    public function __construct(RouteParserInterface $routeParser)
+    public function __construct(private RouteParserInterface $routeParser)
     {
-        $this->routeParser = $routeParser;
     }
 
     /**

diff --git a/src/Application/Renderer/TemplateRenderer.php b/src/Application/Renderer/TemplateRenderer.php
@@ -9,13 +9,12 @@
 
 readonly class TemplateRenderer
 {
-    public function __construct(
-        private PhpRenderer $phpRenderer,
-    ) {
+    public function __construct(private PhpRenderer $phpRenderer)
+    {
     }
 
     /**
-     * Output rendered template.
+     * Render template.
      *
      * @param ResponseInterface $response The response
      * @param string $template Template pathname relative to templates directory