Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct REAME.md #24

Closed
wants to merge 1 commit into from
Closed

Correct REAME.md #24

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2017

Correct READMME.md to reflect how to import environment variables in config files.

Correct `READMME.md` to reflect how to import environment variables in config files.
@ghost
Copy link
Author

ghost commented Jun 10, 2017

Nice library, by the way. Exactly what I needed.

@coveralls
Copy link

coveralls commented Jun 10, 2017

Coverage Status

Coverage remained the same at 90.476% when pulling 9135a44 on odiumediae:patch-1 into 9a99db4 on samueljseay:master.

@samueljseay
Copy link
Owner

The library should support 3 different ways to declare config: https://github.com/samueljseay/recaptcha/releases/tag/2.1.1 I haven't looked in depth in to your issues yet, but I'll see if these still work for me. If you want to update your PR so that the README reflects the release notes that'd be appreciated though.

@samueljseay
Copy link
Owner

@sobolevn you've been following the issues people have had.. do you know if the config currently works as stated in the release docs?

@sobolevn
Copy link
Collaborator

sobolevn commented Jun 12, 2017

@samueljseay I am using {:recaptcha, "~> 2.0}" with not issues.
https://github.com/elixir-lang-moscow/site/blob/master/mix.exs#L59

Here's how the configuration is made: https://github.com/elixir-lang-moscow/site/blob/master/config/config.exs#L77

And my environment variables:

=== elixir-lang-moscow Config Vars
....
RECAPTCHA_PRIVATE_KEY: ....KbVq....
RECAPTCHA_PUBLIC_KEY: ....gurMCr8i...

Live demo: http://elixir-lang.moscow/suggest-talk

@samueljseay
Copy link
Owner

Closing this. I'll make a PR to update the docs to reflect the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants