Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set Jason as default json library if none set #53

Merged
merged 1 commit into from Oct 15, 2019
Merged

set Jason as default json library if none set #53

merged 1 commit into from Oct 15, 2019

Conversation

MyNameIsURL
Copy link
Contributor

No description provided.

@MyNameIsURL MyNameIsURL mentioned this pull request Oct 15, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.333% when pulling f854463 on MyNameIsURL:jason_default_json_lib into 9fc899d on samueljseay:master.

@sobolevn sobolevn merged commit 8ea13f6 into samueljseay:master Oct 15, 2019
@sobolevn
Copy link
Collaborator

Thanks!

@aparod
Copy link

aparod commented Apr 26, 2021

This fix never made it into the 3.0.0 release: https://github.com/samueljseay/recaptcha/blob/3.0.0/lib/recaptcha/http.ex#L43

Currently, we still have to manually configure the json library, or end up with the nil.decode error mentioned above.

@samueljseay samueljseay mentioned this pull request Jul 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MyNameIsURL @coveralls @sobolevn @aparod