Skip to content
This repository has been archived by the owner on Jul 12, 2021. It is now read-only.

Spellcheck #2

Closed
connorhatch opened this issue Jan 24, 2019 · 7 comments
Closed

Spellcheck #2

connorhatch opened this issue Jan 24, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@connorhatch
Copy link

Any plans to implement spellcheck?

@connorhatch connorhatch changed the title Spell check Spellcheck Jan 24, 2019
@samuelmeuli
Copy link
Owner

That's a good idea. I'll look into this.

@samuelmeuli samuelmeuli added the enhancement New feature or request label Jan 24, 2019
samuelmeuli added a commit that referenced this issue Feb 1, 2019
@samuelmeuli
Copy link
Owner

It looks like there isn't a straightforward way to implement spell checking in Electron apps right now. There's electron-spellchecker which unfortunately has lots of issues (broken language auto-detection, performance problems, and no clear way to turn it off) and seems to be unmaintained. Unfortunately, I couldn't find any better alternatives.

It probably makes sense to wait with this feature and keep an eye on electron/electron#3211.

@github2099
Copy link

Any news?

@samuelmeuli
Copy link
Owner

samuelmeuli commented Jul 29, 2019

I've had another look at integrating electron-spellchecker into Mini Diary. There have been improvements, but I'm still not happy with its performance, language detection is broken, and including the library would increase the app size by 25 MB (!). The package also doesn't seem to be very actively maintained. Therefore, I'd rather not merge this into master.

If this feature is very important to someone, you could build the app yourself from the spell-checking branch branch.

And if anyone knows a better solution, I'd be happy to hear it! I'm also still hoping for built-in support for spell checking in Electron :)

@samuelmeuli
Copy link
Owner

Good news: https://github.com/electron/electron/releases/tag/v8.0.0-beta.2

I'll look into this once the app is updated for Electron 8.

@samuelmeuli samuelmeuli self-assigned this Dec 1, 2019
@samuelmeuli
Copy link
Owner

Native spellchecking will be available in the next release :)

@HeyVern
Copy link

HeyVern commented Jul 26, 2020

I see that you added it in preferences....but how does one actually use Spell Check? Did it ever actually make it to the release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants