Removed notify perms from Version characteristic again.

Additional Authorization should not be added by default.
samuelthomas2774 · Oct 19, 2020 · 0a45bbf · 0a45bbf
1 parent 581298f
commit 0a45bbf
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/src/lib/definitions/CharacteristicDefinitions.ts b/src/lib/definitions/CharacteristicDefinitions.ts
@@ -1698,7 +1698,7 @@ export class LockTargetState extends Characteristic {
   constructor() {
     super("Lock Target State", LockTargetState.UUID, {
       format: Formats.UINT8,
-      perms: [Perms.NOTIFY, Perms.PAIRED_READ, Perms.PAIRED_WRITE, Perms.ADDITIONAL_AUTHORIZATION],
+      perms: [Perms.NOTIFY, Perms.PAIRED_READ, Perms.PAIRED_WRITE],
       minValue: 0,
       maxValue: 1,
       minStep: 1,
@@ -3576,7 +3576,7 @@ export class TargetDoorState extends Characteristic {
   constructor() {
     super("Target Door State", TargetDoorState.UUID, {
       format: Formats.UINT8,
-      perms: [Perms.NOTIFY, Perms.PAIRED_READ, Perms.PAIRED_WRITE, Perms.ADDITIONAL_AUTHORIZATION],
+      perms: [Perms.NOTIFY, Perms.PAIRED_READ, Perms.PAIRED_WRITE],
       minValue: 0,
       maxValue: 1,
       minStep: 1,
@@ -4098,7 +4098,7 @@ export class Version extends Characteristic {
   constructor() {
     super("Version", Version.UUID, {
       format: Formats.STRING,
-      perms: [Perms.NOTIFY, Perms.PAIRED_READ],
+      perms: [Perms.PAIRED_READ],
       maxLen: 64,
     });
     this.value = this.getDefaultValue();

diff --git a/src/lib/definitions/generate-definitions.ts b/src/lib/definitions/generate-definitions.ts
@@ -598,6 +598,10 @@ function generatePermsString(propertiesBitMap: number): string {
   const perms: string [] = [];
 
   for (const [bitMap, name] of properties) {
+    if (name === "ADDITIONAL_AUTHORIZATION") {
+      // aa set by homed just signals that aa may be supported. Setting up aa will always require a custom made app though
+      continue;
+    }
     if ((propertiesBitMap | bitMap) === propertiesBitMap) { // if it stays the same the bit is set
       perms.push("Perms." + name);
     }

diff --git a/src/lib/definitions/generator-configuration.ts b/src/lib/definitions/generator-configuration.ts
@@ -73,6 +73,16 @@ export const CharacteristicManualAdditions: Map<string, GeneratedCharacteristic>
     minValue: 0,
     maxValue: 360,
   }],
+  ["version", { // don't know why, but version has notify permission even if it shouldn't have one
+    id: "version",
+    UUID: "00000037-0000-1000-8000-0026BB765291",
+    name: "Version",
+    className: "Version",
+
+    format: "string",
+    properties: 2, // paired read
+    maxLength: 64,
+  }]
 ]);
 
 export const ServiceNameOverrides: Map<string, string> = new Map([