Allow credentials to be configured via an environment variable #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camh-
previously approved these changes
May 24, 2021
credentials.go
Outdated
| at := strings.IndexRune(e.value, '@') | ||
| colon := strings.IndexRune(e.value, ':') | ||
| if at == -1 || colon == -1 || at > colon { | ||
| return nil, errors.New("invalid $NTLM_CREDENTIALS, please run `alpaca -H`") |
There was a problem hiding this comment.
Technically, this bit of code has no idea about envvars or specifically the NTLM_CREDENTIALS var. It really is just a string source, which could also be used later when implementing a config file.
Also I wonder whether the parsing of user@domain:hash belongs in authenticator, much as I suggested elsewhere that the formatting of the three fields perhaps belongs in a String() function on authenticator. At the moment, knowledge of this format is split between here and main().
akingatwork
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows non-interactive use of Alpaca on Linux and Windows.