Pass complete URLs to PAC script, assuming https if scheme is empty #72
Conversation
Also change FindProxyForURL() to pass by value rather than by reference. This function modifies the URL, so do that on a copy rather than the original. Fixes #58
| if u.Scheme == "" { | ||
| // When a net/http Server parses a CONNECT request, the URL will | ||
| // have no Scheme. In that case, assume the scheme is "https". | ||
| u.Scheme = "https" |
There was a problem hiding this comment.
This could be a little smarter by looking at the port if specified. All the CONNECT examples specify it, but a quick reading of the spec suggests that maybe port is not mandatory. But if port is 80, you could probably safely assume http and not https.
There was a problem hiding this comment.
I was considering that, but decided against it because I didn't want to have to maintain a mapping. It would be nice if we could use something like this services map, which is exposed in net.LookupPort(), although that mapping is going in the opposite direction to what we'd need here.
Also iiuc port 80 could mean ws:// too, and maybe that's more likely to be the case when someone does a CONNECT request to port 80?
There was a problem hiding this comment.
There was a problem hiding this comment.
There is I guess there is a registry - I thought it was a free-for-all./etc/services too - presumably any of them could have a scheme.
Also change FindProxyForURL() to pass by value rather than by reference. This
function modifies the URL, so make sure to do that on a copy rather than on the
original.
Fixes #58