Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSetActor.create_content blows up with a local file #483

Closed
hectorcorrea opened this issue Nov 23, 2015 · 1 comment
Closed

FileSetActor.create_content blows up with a local file #483

hectorcorrea opened this issue Nov 23, 2015 · 1 comment

Comments

@hectorcorrea
Copy link
Contributor

Methods FileSetActor.create_content and FileSetActor.copy_file_to_working_directory work only when the file passed is an UploadedFile, but throw errors when the file passed is a plain Ruby File object. See https://github.com/projecthydra-labs/curation_concerns/blob/master/curation_concerns-models/app/actors/curation_concerns/file_set_actor.rb#L50-L59

Both of these methods expects properties not found in a regular File object, in particular original_filename, and content_type.

This is not detected in the current test suite because (1) we are only testing with a Rack::Test::UploadedFile and (2) the double used in ingest_local_file_job_spec.rb is masking the problem.

@jcoyne
Copy link
Contributor

jcoyne commented Nov 23, 2015

@hectorcorrea Colin is already taking care of this in #460

@grosscol grosscol closed this as completed Dec 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants