Skip to content

Orcid v0.8.1 - tidying up internals

Pre-release
Pre-release
Compare
Choose a tag to compare
@jeremyf jeremyf released this 23 May 15:25
· 99 commits to master since this release

2014-05-15: Introducing ProfileRequestCoordinator [Jeremy Friesen]

Responsible for converting an Orcid::ProfileRequest into an
Orcid::Profile.

The Orcid::ProfileRequest object was doing too many things (i.e.
persisting the profile request then handling the remote interaction
with orcid.org).

I'm trying to tease apart the offline coordinator for the profile
request. Basically separating the persistence of the initial request
to processing that persisted request.

Also, this pull request includes adjusting Orcid exceptions
inheritance.

I want to provide a base error from which Orcid errors are built
from. That way, someone could feasibly rescue an Orcid::BaseError
exception and handle in a uniform manner.

2014-05-21: Updating README to declare no Hydra dependencies [Jeremy Friesen]

2014-05-21: Expanding code coverage [Jeremy Friesen]

2014-05-21: Adjusting collaborators for ProfileConnection [Jeremy Friesen]

Moving the questionable dependency injection from the save method to
the instantiation process.

Also moving the specs for ProfileConnection to run faster (i.e I
don't need to load the entire Rails ecosystem).

2014-05-20: Improving on code coverage [Jeremy Friesen]

* Adding additional test for query parameter
* Adding spec to make sure I am querying works
   The code coverage indicated that I was not yet hitting the remote
   work service.
* The ProfileQueryService was missing a few points in the code
   coverage. These changes address that and remove some of the
   dependency injection in the specs.

2014-05-19: Adding additional badges [Jeremy Friesen]

* API Docs badge
* Contributing Guidelines
* APACHE2 License

2014-05-20: Teasing apart when coveralls runs [Jeremy Friesen]

I noticed that if Simplecov was running and Coveralls was also
configured within the same block, that the Simplecov ./coverage
directory was not being updated.

This is an effort to tease that apart.

2014-05-20: Adding Coveralls support [Jeremy Friesen]

I want to make sure that code coverage information is clearly
displayed.

More available at http://coveralls.io/

2014-05-19: Extracting response parser collaborators [Jeremy Friesen]

2014-05-19: Extracting explicit Orcid::Profile collaborators [Jeremy Friesen]

2014-05-19: Fixing the build for the XmlParser [Jeremy Friesen]

2014-05-19: Adding some @todos for ProfileStatus [Jeremy Friesen]

2014-05-19: Tweaking configuration options [Jeremy Friesen]

Extracting default_template as a method to improve clarity

2014-05-19: Adding mailmap for author disambiguation [Jeremy Friesen]

Some of the authors on the project have commits under two different
identities. Making sure those authors are counted as one.

2014-05-15: Updating gemspec metadata [Jeremy Friesen]

2014-05-15: Adding feature descriptions to the README [Jeremy Friesen]