Allows contact form email address to be set via an environment variable #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 31, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_r...
/app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:inrequire': cannot load such file -- rubocop-rspec (LoadError)<br> from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:15:inblock in resolve_requires'
from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:ineach'<br> from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader_resolver.rb:11:inresolve_requires'
from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:40:inload_file'<br> from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_loader.rb:105:inconfiguration_from_file'
from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/config_store.rb:44:infor'<br> from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:93:inapply_default_formatter'
from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/lib/rubocop/cli.rb:25:inrun'<br> from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:13:inblock in <top (required)>'
from /app/vendor/ruby-2.3.1/lib/ruby/2.3.0/benchmark.rb:308:inrealtime'<br> from /app/vendor/bundle/ruby/2.3.0/gems/rubocop-0.46.0/bin/rubocop:12:in<top (required)>'
from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:inload'<br> from /app/vendor/bundle/ruby/2.3.0/bin/rubocop:23:in'
|
@bbranan Having a look now. |
|
I don't believe the CI failures are related to this work. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1174
Changes contact email config value to pull from settings.yml, allowing the value to be set via an environment variable. Also fixes the comment in settings.yml that indicates how to set values via an environment variable.
Note; I think this should work, but don't have a local environment set up that allows testing this change. Comments and testing are welcome.