Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test compatibility with Hyrax 3.* #197

Open
ebenenglish opened this issue Oct 30, 2019 · 2 comments
Open

test compatibility with Hyrax 3.* #197

ebenenglish opened this issue Oct 30, 2019 · 2 comments

Comments

@ebenenglish
Copy link
Collaborator

We need to test NewspaperWorks against Hyrax v3.0.0-rc* releases to see what, if anything, will need to be done to support Hyrax 3.*.

If it is not possible to support both Hyrax 2.5/2.6 and Hyrax 3, we will need to create a new release of the gem, possibly as 2.0.0.

@ebenenglish
Copy link
Collaborator Author

Initial work being done on hyrax-3 branch.

All specs are passing as of 10ea028.

However, there may be some updates to view partials in app/views/hyrax/base etc. that will need to be checked against view partials in app/views/newspaper_works/base.

@seanupton
Copy link
Collaborator

@ebenenglish I am pretty sure that I still need to port this over, too, now that you mention it: samvera/hyrax@323fcb9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants