Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramp video player UI updates #190

Closed
5 tasks
elynema opened this issue May 25, 2023 · 1 comment · Fixed by #199
Closed
5 tasks

Ramp video player UI updates #190

elynema opened this issue May 25, 2023 · 1 comment · Fixed by #199
Assignees

Comments

@elynema
Copy link

elynema commented May 25, 2023

Description

Based on investigation and review from Avalon #5176, we want to make some tweaks to the buttons in the Ramp video player.

Changing the configuration of Ramp. This list can be internal—things that don't need to be exposed for implementers to pass through in their own configurations.

Done Looks Like

  • Add large overlay play button to middle of player when video is not playing (video.js can do this)
  • Change timestamp to format like YouTube (/) and position on right side of progress bar
  • Captions: style so that CC button looks different when captions are on vs. off (Dananji suggested transparent background with white text vs. current style of white background with transparent text)
  • Remove picture in picture button because provided by browser - both Firefox and Chrome - is this something that could be configured outside of Ramp or is it a core change in Ramp?
    • Prop added to mediaplayer component so it doesn't have to be set up unless explicit
@Dananji
Copy link
Collaborator

Dananji commented Jun 14, 2023

Changing the CC button icon when captions are turned on is not something that is possible yet in VideoJS. But there's work in progress in VideoJS which might provide this functionality in a future release.
So for now, we are using a similar approach as the current Avalon player to indicate captions are on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants