ChangeSet#multiple? returns false rather than nil.

The rails tag helper interprets `required=>nil` as `"required"=>""` which is a required field.
samvera · Oct 31, 2017 · fdb2516 · fdb2516
1 parent ec77913
commit fdb2516
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/valkyrie/lib/valkyrie/change_set.rb b/valkyrie/lib/valkyrie/change_set.rb
@@ -38,7 +38,7 @@ def multiple?(field)
     # @param field [Symbol]
     # @return [Boolean]
     def required?(field)
-      self.class.definitions[field.to_s][:required]
+      self.class.definitions[field.to_s][:required] == true
     end
 
     # Quick setter for fields that should be in a changeset. Defaults to multiple,

diff --git a/valkyrie/spec/valkyrie/change_set_spec.rb b/valkyrie/spec/valkyrie/change_set_spec.rb
@@ -37,8 +37,9 @@ class ResourceChangeSet < Valkyrie::ChangeSet
     it "is true when marked" do
       expect(change_set.required?(:title)).to eq true
     end
+
     it "is false when not marked" do
-      expect(change_set.required?(:files)).not_to eq true
+      expect(change_set.required?(:files)).to eq false
     end
   end