Document Memory & Solr Adapters. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Jul 10, 2017
| def initialize(object) | ||
| @object = object | ||
| end | ||
|
|
||
| # @return The solr document ID |
| class SolrRow | ||
| attr_reader :key, :fields, :values | ||
| # @param key [Symbol] Solr key. | ||
| # @param fields [Array<Symbol>] Field suffixes to index into. | ||
| # @param values [Array<>] Values to index into the given fields. |
There was a problem hiding this comment.
Just Array or provide the inner type here.
| def initialize(key, value, scope = []) | ||
| @key = key | ||
| @value = value | ||
| @scope = scope | ||
| end | ||
| end | ||
|
|
||
| ## | ||
| # Represents a row in the solr document, used for isolating logic around |
There was a problem hiding this comment.
Solr doesn't have rows, so this seems forced, but it might require a class name change.
There was a problem hiding this comment.
Agreed. Changed the comment a little - regarding the name change, if you can think of a better name put in a ticket? It's internal, but naming's important.
tpendragon
force-pushed
the
documentation
branch
from
327cbe2
to
313bdc9
Compare
jcoyne
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to get this in one step at a time so that we're all good with everything before I do too much work and have to back track.