Allow the descendant fetcher to be more flexible by grouping uris by model #1275
Conversation
| partitioned_uris[:priority] << rdf_resource.subject | ||
| else | ||
| partitioned_uris[:other] << rdf_resource.subject | ||
| rdf_graph_models.each do |model| |
There was a problem hiding this comment.
If we're not using the prioritized_object? method anymore, should it be deleted?
There was a problem hiding this comment.
Good catch, I'll take it out.
|
Is this new behavior API-compatible with old behavior, people setting "priority models" can still set them in the old way and get the same behavior? I think maybe so, can you confirm @cjcolvar ? |
|
@cjcolvar could it use any more docs explaining this use of |
|
@jrochkind yes, I was intending to make it backwards compatible. I didn't touch the tests and they still pass |
|
Awesome, thanks @cjcolvar, appreciate it! |
|
@jrochkind This is ready for rereview now. |
|
@cjcolvar Looks like you already have approval and just need a rebase |
This PR preserves previous functionality for grouping uris by priority/other but also adds the capability to get the uris grouped by model if you call
descendant_and_self_uris_partitioned_by_modeldirectly.