Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the case where active_encode returns a 'cancelled' status #150

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Handle the case where active_encode returns a 'cancelled' status #150

merged 2 commits into from
Apr 11, 2017

Conversation

val99erie
Copy link
Contributor

@val99erie val99erie requested a review from cjcolvar April 6, 2017 16:24
@val99erie val99erie mentioned this pull request Apr 6, 2017
Merged
@cjcolvar
Copy link
Member

👍 Looks good. Could you make rubocop happy? Then if travis is happy I'll merge it.

cjcolvar
cjcolvar requested changes Apr 10, 2017
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix rubocop warnings

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a2badd6 on cancelled_status into ** on active_encode_dev_con**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling a2badd6 on cancelled_status into ** on active_encode_dev_con**.

@cjcolvar cjcolvar merged commit a831f7c into active_encode_dev_con Apr 11, 2017
@cjcolvar cjcolvar deleted the cancelled_status branch April 11, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@val99erie @cjcolvar @coveralls