Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development Environment Configuration #204

Merged
merged 5 commits into from
Jul 31, 2019
Merged

Development Environment Configuration #204

merged 5 commits into from
Jul 31, 2019

Conversation

tpendragon
Copy link
Contributor

  1. Fix Solr configuration to use 7.x locally (like CircleCI)
  2. Add documentation on dependencies to run tests locally.
  3. Fix periodically failing spec.
  4. Add local coverage generation.

@tpendragon tpendragon force-pushed the development_environment branch 2 times, most recently from 6ed4564 to e3cd440 Compare July 30, 2019 19:10
@tpendragon tpendragon added this to Review in Component Maintenance via automation Jul 30, 2019
botimer
botimer requested changes Jul 30, 2019
View reviewed changes
README.md Outdated
## Dependencies

* [ImageMagick](https://www.imagemagick.org)
* On a mac, do `brew install imagemagick --with-little-cms2 --with-openjpeg`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of Homebrew 2.0.0, homebrew-core accepts no options and uses both of these by default.

spec/units/derivatives_spec.rb Outdated
@@ -40,6 +40,12 @@ class CustomFile < ActiveFedora::Base
end
end
describe "#{method}=" do
around do |obj|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this save/restore usually done as follows?

around(:each) do |example|
  ..
  example.run
  ..
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example.run is definitely better. Rubocop complains about (:each).

@botimer
Copy link
Contributor

botimer commented Jul 30, 2019

Following the updated README (without imagemagick options) gave me a fully passing suite. Once that's addressed, 🚢.

@tpendragon
Copy link
Contributor Author

@botimer Sorry, this should be ready now. Was lost in coverage fixing.

@botimer botimer merged commit 9d4bcbc into master Jul 31, 2019
Component Maintenance automation moved this from Review to Done Jul 31, 2019
@botimer botimer deleted the development_environment branch July 31, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botimer botimer botimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Component Maintenance
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tpendragon @botimer