Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating activesupport to support Rails 6.x releases #221

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Updating activesupport to support Rails 6.x releases #221

merged 2 commits into from
Nov 16, 2020

Conversation

jrgriffiniii
Copy link
Contributor

@jrgriffiniii jrgriffiniii force-pushed the rails6-update branch 2 times, most recently from 5f296fe to eea1916 Compare June 9, 2020 16:02
@jrgriffiniii
Copy link
Contributor Author

After updating this using samvera/active_fedora@master...jrgriffiniii:rails6-update yields the following errors:

sprockets-4.0.0 requires ruby version >= 2.5.0, which is incompatible with the current version, ruby 2.4.10p364

@jrgriffiniii
Copy link
Contributor Author

This is now stable, but I'm going to need a new release of active-fedora in order to support this.

@jrgriffiniii jrgriffiniii mentioned this pull request Jun 9, 2020
Merged
@jrgriffiniii jrgriffiniii marked this pull request as draft June 9, 2020 18:38
@jrgriffiniii
Updating activesupport to support Rails 6.x releases; Updating RuboCop;
580a406 
Adding pry-byebug as a dev. dependency; Locking the sprockets dependency
to 3.7.z releases (in order to support legacy Rails releases);
@jrgriffiniii
Copy link
Contributor Author

This is blocked by samvera/active_fedora#1421 and another release for active_fedora.

@jrgriffiniii jrgriffiniii mentioned this pull request Jun 10, 2020
Merged
@jrgriffiniii jrgriffiniii added this to Review in Component Maintenance via automation Jun 10, 2020
@jrgriffiniii jrgriffiniii moved this from Review to In Progress in Component Maintenance Jun 10, 2020
@jrgriffiniii jrgriffiniii moved this from In Progress to Blocked in Component Maintenance Jun 12, 2020
@cjcolvar cjcolvar mentioned this pull request Nov 16, 2020
Merged
@jeremyf jeremyf merged commit d7e9065 into samvera:master Nov 16, 2020
Component Maintenance automation moved this from Blocked to Done Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Component Maintenance
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrgriffiniii @jeremyf